Implement experimental workaround for Android Server pairing #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new android platform introduced in 6.5.0 made the app be served from the HTTPS context by default. This broke pairing, because requests to Server are sent via insecure HTTP (we use our own TLS certificate to secure the communication once pairing is complete) and chrome disallows "mixed content" requests. I implemented a preference here that forces the app to load from HTTP, which "fixes" the issue, but it has some drawbacks: - Some browser features are disabled when loaded from an insecure context. We don't know what these are, exactly. - iOS uses its own preference for 'scheme', so pairing is presumably still broken there.
This is an attempt to fix duplicate headers in the csv export. It replaces the node stream functionality with simple string writing, and uses papa parse instead of constructing the csv manually. It doesn't seem to work!
…etwork-exporters reference
…va-csv-write attempt to fix csv writing on cordova by replacing streaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new android platform introduced in 6.5.0 made the app be served from the HTTPS context by default. This broke pairing, because requests to Server are sent via insecure HTTP (we use our own TLS certificate to secure the communication once pairing is complete) and chrome disallows "mixed content" requests.
I implemented a preference here that forces the app to load from HTTP, which "fixes" the issue, but it has some drawbacks: