Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment with dom builder approach to XML generation #204

Draft
wants to merge 9 commits into
base: next
Choose a base branch
from
Draft

experiment with dom builder approach to XML generation #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
71a8a10
experiment with dom builder approach to XML generation
jthrilly Nov 11, 2024
7e20c6f
remove obsolete tests
jthrilly Nov 11, 2024
cefbcf1
remove jssha
jthrilly Nov 11, 2024
8ef68f3
small TS changes
jthrilly Nov 11, 2024
a60c770
Merge branch 'next' into graphml-xml-dom
jthrilly Nov 11, 2024
ebf0e3e
resolve some ts issues
buckhalt Nov 11, 2024
7fef51d
Merge branch 'graphml-xml-dom' of https://github.com/complexdatacolle…
buckhalt Nov 11, 2024
f9fdff3
WIP types
jthrilly Nov 12, 2024
6b68622
WIP
jthrilly Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"WillLuke.nextjs.addTypesOnSave": true,
"WillLuke.nextjs.hasPrompted": true,
"editor.codeActionsOnSave": {
"source.organizeImports": "always"
"source.organizeImports": "always",
"source.fixAll": "always",
}
}
2 changes: 1 addition & 1 deletion actions/interviews.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const exportSessions = async (
.then(insertEgoIntoSessionNetworks)
.then(groupByProtocolProperty)
.then(resequenceIds)
.then(generateOutputFiles(formattedProtocols, exportOptions))
.then(generateOutputFiles(formattedProtocols, exportOptions)) // Contains partitionByType
.then(archive)
.then(uploadZipToUploadThing);

Expand Down
23 changes: 0 additions & 23 deletions lib/network-exporters/formatters/graphml/__tests__/createGraphML.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,27 +174,4 @@ describe('buildGraphML', () => {
'mock-uuid-5': 'node',
});
});

describe('with directed edge option', () => {
beforeEach(() => {
const processedNetworks = processMockNetworks(
[mockNetwork, mockNetwork2],
false,
);
const protocolNetwork = processedNetworks['protocol-uid-1'][0];

xml = buildXML(protocolNetwork, codebook, {
...exportOptions,
globalOptions: {
useDirectedEdges: true,
},
});
});

it('specifies directed edges', () => {
expect(
xml.getElementsByTagName('graph')[0].getAttribute('edgedefault'),
).toEqual('directed');
});
});
});
Loading