Remove flag for ignoring undefined symbols for a wasm build #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The undefined symbols occuring during the xeus-cpp build against emscripten is now fixed. This is fixed because we did a shared build for cppinterOp which exposes all required symbols out of clangInterpreter (emscripten-forge/recipes#1454) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 19 19
Lines 974 974
Branches 93 93
=======================================
Hits 787 787
Misses 187 187 |
anutosh491
force-pushed
the
anutosh491-patch-2
branch
from
2acd1b3 to
afaa39a
Compare
|
Small change. Merging as ready. This pr works on top of the benefits provided by other PRs linked above which did most of the heavy lifting. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #159
Type of change
Please tick all options which are relevant.