Refactor Xassist, Test Framework #161
Conversation
tharun571
force-pushed
the
xassist
branch
3 times, most recently
from
ce69831 to
23e4ff7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 81.83% 80.67% -1.17%
==========================================
Files 19 19
Lines 837 864 +27
Branches 91 93 +2
==========================================
+ Hits 685 697 +12
- Misses 152 167 +15
... and 2 files with indirect coverage changes
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Just curious as to what exactly the refactor is doing here ? Maybe explain through a simple example ? |
I was going through whatever code I wrote and checked for possible bugs. This PR takes care of scenarios when the prompt has special characters or anything involving disrupting the JSON to call the LLM. |
| } | ||
| return escaped; | ||
| } | ||
|
|
There was a problem hiding this comment.
This PR takes care of scenarios when the prompt has special characters or anything involving disrupting the JSON to call the LLM.
Hmm, so should there be a test required in this PR to check this claim ?
There was a problem hiding this comment.
Hmm, so should there be a test required in this PR to check this claim ?
I did try but got in a predicament where escape_special_cases("""{}") == "\"\"{}" yields false but works in the kernel. So I tested them manually and pushed the code
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Description
Type of change
Please tick all options which are relevant.