-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restoring old config file #150
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to keep the XEUS_CPP_VERSION_LABEL
token, and read it from the config file like the other ones.
clang-tidy review says "All clean, LGTM! 👍" |
I am lost. Why do we undo the work being done in this area? |
As said in the original PR, the building tool should not inject anything in the source code, this makes the code depending on the building tool. The original PR was merged to get the inspect feature work until we find a better solution. Now that we have one, we don't need the build tool to inject anything in the source code anymore and we can revert to the original behavior. |
Ok, good. I misread the pull request on my phone. Apologies. LGTM! |
Description
Addressing this comment raised by Johan
Type of change
Please tick all options which are relevant.