Heroku deploy resurrection #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting 'NodeError: write after end at writeAfterEnd' from node_modules/winston
metasoarous
commented
Mar 29, 2023
server/src/config.ts
Outdated
| @@ -65,6 +65,7 @@ export default { | |||
| emailTransportTypes: process.env.EMAIL_TRANSPORT_TYPES || null as string | null, | |||
| encryptionPassword: process.env.ENCRYPTION_PASSWORD_00001 as string, | |||
| fbAppId: process.env.FB_APP_ID || null as string | null, | |||
| logTransport: process.env.SERVER_LOG_TRANSPORT as string, | |||
There was a problem hiding this comment.
This may have snuck in due to the squash-merge process mucking up the diffs when I merged edge into my branch :-/
There was a problem hiding this comment.
yeah you can remove that line
metasoarous
commented
Mar 29, 2023
heroku.yml
Outdated
There was a problem hiding this comment.
Should probably fully remove release phase before merging, unless we think there's some chance we'll stick with heroku and try to resurrect this.
metasoarous
force-pushed
the
heroku-deploy-resurrection
branch
from
44f25e6 to
cc989f8
Compare
ballPointPenguin
approved these changes
Apr 9, 2023
xeeg
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards fixing up the heroku deploy strategy as a stop gap in case we can't move to AWS+Kubernetes as soon as we hope.
Basically:
API_SERVER_PORTto fallback toPORT, which is a requirement for Herokureleasephase fromheroku.yml, which was problematic in previous attempts to move static asset deploy to heroku for full "one click (command?)" deploy (we don't really need this for now, especially if this is just a stop gap)Still having problems with static assets being fetched, which may be a configuration issue.