Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web Components] Input/Edit does not render #76

Closed
kidroca opened this issue Jul 21, 2021 · 2 comments · Fixed by #90
Closed

[Web Components] Input/Edit does not render #76

kidroca opened this issue Jul 21, 2021 · 2 comments · Fixed by #90
Assignees

Comments

@kidroca
Copy link
Contributor

kidroca commented Jul 21, 2021

There's an error:

Uncaught ReferenceError: Fragment is not defined

Maybe we would have to use a wrapper element like div instead of a Fragment so that the React component can be converted correctly

kidroca added a commit that referenced this issue Jul 21, 2021
Using the fragment shorthand <> does not translate to `web-components`

Related to #76
@kidroca
Copy link
Contributor Author

kidroca commented Jul 21, 2021

This is partially fixed but I found another issue happening
image

The way React-Web is build assets paths might be referenced incorrectly
image

The components bundled in index.js are referencing check~UBWjaIYR.svg as src="check~UBWjaIYR.svg" which does not resolve from the project folder of the web-components
We should somehow tell the src that the image is in the same folder, or copy the dist content when we build the web-components project
The problem might also be in the web components conversion ...

@kendrick
Copy link
Contributor

The 3 SVGs in the screenshot should eventually be converted to Icon components, which I think will solve the issue. If we’re not ready to implement Icons here yet, copying the SVG to web-components and referencing it locally is fine for the short-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants