Fix jumping to begining of day on group message #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356
Issue:
The existing implementation utilizes
chat.dayGCMsgs.lengthto determine the scroll position, which represents the count of grouped days, not the individual messages. This causes the scroll to navigate to the initial message of the last grouped day, leading to incorrect scroll behavior.Solution:
This PR addresses the scrolling inconsistency by flattening the grouped messages and incorporating an additional count for day change messages. This ensures that the scroll position accurately reflects the individual message count, preserving the day change messages.