Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be less restrictive about dependencies versions and solve elixir 1.4 warnings #5

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

Nagasaki45
Copy link
Contributor

Some minor changes to mix.exs that I found necessary.

@jordan0day
Copy link
Contributor

D'oh, sorry, for some reason I wasn't getting any github notifications for this project. Thanks for the 1.4 fixes, but I prefer a little more caution on the versioning.

@Nagasaki45
Copy link
Contributor Author

Nagasaki45 commented Feb 16, 2017

Hi @jordan0day, thanks for your response.

I'm relatively new to elixir. In a project I'm working on I already have jose, httpoison, and poison as dependencies, but with different versions than those specified by big_query. I proposed this commit as it solved the issue for me and I couldn't see any downside, but maybe I'm wrong.
I would like to improve this PR, maybe by completely droping the 1st commit, please let me know what would you prefer.

@jordan0day
Copy link
Contributor

Mix does have a decent workaround for your type of scenario, in your mix.exs where you're using newer versions of those libraries, you can specify override: true to basically tell mix "This is the version I really want to use!" Ex:

{:jose, "1.8.1", override: true}

If you want to drop the first commit for now, I'll test the library against the latest versions of those dependencies when I get a chance and maybe bump them then. Thanks again!

@Nagasaki45
Copy link
Contributor Author

I dropped the versioning changes commit from the PR. Thank you very much for the tip! I learned something new :-)

@jordan0day jordan0day merged commit 5ef3ff4 into companykitchen:master Feb 16, 2017
Nagasaki45 added a commit to Nagasaki45/krihelinator that referenced this pull request Feb 18, 2017
@gVolop gVolop mentioned this pull request Mar 5, 2017
@gVolop
Copy link
Contributor

gVolop commented Mar 5, 2017

#7 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants