Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DOCKER_BUILDKIT=0 flag for Docker builds #192

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Use DOCKER_BUILDKIT=0 flag for Docker builds #192

merged 1 commit into from
Dec 8, 2020

Conversation

DamianDunajski
Copy link
Contributor

Docker releases >=2.4.0.0 have BuildKit enabled by default - this breaks image builds due to a known issue (moby/buildkit#816) with BuildKit and ONBUILD COPY --from directives which we use in our runtime image.

Prefixing docker build commands with DOCKER_BUILDKIT=0 fixes the issue

akaJSaunders
akaJSaunders approved these changes Dec 8, 2020
View reviewed changes
Copy link

@akaJSaunders akaJSaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💇‍♂️ looking good

@DamianDunajski DamianDunajski merged commit 72751f5 into master Dec 8, 2020
@DamianDunajski DamianDunajski deleted the patch-1 branch December 8, 2020 11:29
@softworm softworm mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaJSaunders akaJSaunders akaJSaunders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamianDunajski @akaJSaunders