Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autograder: ::error::The output for test galosh.js JSON did not match #17

Open
chaynickUNC opened this issue Nov 17, 2022 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@chaynickUNC
Copy link

Delete text above this line before you submit your issue. Place your issue information in the appropriate sections below.

Which autograder check is failing?

::error::The output for test galosh.js JSON did not match

What is happening?

The output of my code does not match what the autograder expects, even when they appear to be the exact same.

Failed workflow run URL

https://github.com/comp426-2022-fall/a02-chaynickUNC/actions/runs/3390630486/jobs/5634991842

What should be happening?

The autograder should compare what is expected to the code's output, and allowing the test to pass.

Screenshots of your local test(s)

Why do you think the autograder is failing?

One of the data points returned by OpenMeteo is not in the range of acceptable values

@chaynickUNC chaynickUNC added the bug Something isn't working label Nov 17, 2022
@vennila-t
Copy link

vennila-t commented Nov 17, 2022

Hey Nicholas,

I looked through your code and realized that you didn't have a statement for what would happen if your command line argument was "-j". This is the test/command that is currently failing in the autograder. I would add a conditional statement for what your program should do in this scenario. Hint: should start with if( args.j). Once you figure out what to write, this should fix your issue. Let me know if you have additional questions

@chaynickUNC
Copy link
Author

chaynickUNC commented Nov 17, 2022 via email

@vennila-t
Copy link

vennila-t commented Nov 17, 2022

Ohh I see. I missed that line.

However, In line 14, I notice that in your const response , for fetch you already have the default test values for latitude, longitudes, etc. instead of inserting variables in your url. You need to insert your variables instead. the format should be "https://api.open-meteo.com/v1/forecast?latitude= + latitude " instead of "https://api.open-meteo.com/v1/forecast?latitude=35.875" and this should be done for every variable in the url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants