Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 sol navigation #11

Merged
merged 3 commits into from
Mar 26, 2023
Merged

8 sol navigation #11

merged 3 commits into from
Mar 26, 2023

Conversation

wastilla
Copy link
Contributor

No description provided.

KrisJordan and others added 3 commits March 24, 2023 10:40
Factored out separate create vs. update methods.

Made the signature of create and update in the user service idiomatic (subject first, user model second) and improved permission check to have both feature-specific rule (a user can edit their own profile), as well as administrative permission check.
Add [docs/auth.md](docs/auth.md) with a conceptual introduction to authentication and authorization concerns for both backend and frontend.

Additionally, provide guidance on common concerns.

Finally, improve documentation of backend's `authentication.py` for more insight on implementation of authentication.
Implemented forum router link so user can access forum page via the navigation bar
Copy link
Contributor

@wquadland wquadland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aayush110 aayush110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@wastilla wastilla merged commit c2a2927 into stage Mar 26, 2023
@wastilla wastilla linked an issue Apr 3, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Navigation Route to Forum
4 participants