Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multi commit issue #4164

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Fix/multi commit issue #4164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3bcf07
avoid unnecessary github initialization
umeshlumbhani247 Nov 7, 2023
bba710e
Merge remote-tracking branch 'origin/main' into fix/multi_commit_issue
umeshlumbhani247 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cla-backend/cla/models/github_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1448,6 +1448,7 @@ def update_pull_request(installation_id, github_repository_id, pull_request, rep
if missing:
text = ''
help_url = ''

for user_commit_summary in missing:
# Check for valid GitHub id
# old tuple: (sha, (author_id, author_login_or_name, author_email, optionalTrue))
Expand All @@ -1457,7 +1458,7 @@ def update_pull_request(installation_id, github_repository_id, pull_request, rep
help_url = cla.utils.get_full_sign_url('github', str(installation_id), github_repository_id,
pull_request.number, project_version)

client = GitHubInstallation(installation_id)

# check if unsigned user is whitelisted
if user_commit_summary.commit_sha != last_commit.sha:
continue
Expand All @@ -1476,6 +1477,7 @@ def update_pull_request(installation_id, github_repository_id, pull_request, rep
"text": text,
},
}
client = GitHubInstallation(installation_id)
client.create_check_run(repository_name, json.dumps(payload))

# Update the comment
Expand Down
Loading