Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributor Console - "CCLA whitelist request already exist" message is displayed even when the user is requesting for the whitelist for the first time #841

Closed
nirupamav opened this issue Apr 9, 2020 · 0 comments · Fixed by #846
Closed

Contributor Console - "CCLA whitelist request already exist" message is displayed even when the user is requesting for the whitelist for the first time #841

nirupamav opened this issue Apr 9, 2020 · 0 comments · Fixed by #846
Assignees
@amolsontakke3576
Labels
bug Something isn't working

Comments

@nirupamav
Copy link

Background

Prerequisite

  1. Project NiruOnlyCCLA with ccla enabled should exist
  2. Company Apr09Comp2 should exist and should not have signed cla

Steps to follow

  1. Launch github repository url https://github.com/uftautomation/desktop-prod

  2. Login as github user

  3. Update any file and Pull Request

  4. Checks fail

  5. Click on CLA NOT SIGNED

  6. Click on Corporate

  7. Select Company Apr09Comp2

  8. Popup to request authorization is displayed

  9. Select employee Email ID
    image

  10. Click SEND button
    image

image

  1. Observed that "CCLA whitelist request already exist" message is displayed even if the whitelist request for the company is made for the first time

Tried to create a new company and tried to request for whitelist and observed same issue
image

image

image
@nirupamav nirupamav added the bug Something isn't working label Apr 9, 2020
@nirupamav nirupamav mentioned this issue Apr 9, 2020
Closed
amolsontakke3576 added a commit that referenced this issue Apr 9, 2020
@amolsontakke3576
#841 Error message even company is new
43f7ad5 
Signed-off-by: Amol Sontakke <[email protected]>
@amolsontakke3576 amolsontakke3576 self-assigned this Apr 9, 2020
@amolsontakke3576 amolsontakke3576 linked a pull request Apr 9, 2020 that will close this issue
Contributor Console - "CCLA whitelist request already exist" message is displayed even when the user is requesting for the whitelist for the first time #846
Merged
dealako added a commit that referenced this issue Apr 10, 2020
@amolsontakke3576 @dealako
Contributor Console - "CCLA whitelist request already exist" mes… (#846)
b64c888 
* #807 Working on changing endpoints
* #807 added new endpoint and handled errors
* #841 Error message even company is new

Signed-off-by: Amol Sontakke <[email protected]>

Co-authored-by: David Deal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amolsontakke3576 amolsontakke3576

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@amolsontakke3576 @nirupamav