Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting another Signatory flow is not working #4247

Closed
1 of 14 tasks
jarias-lfx opened this issue Feb 16, 2024 · 13 comments
Closed
1 of 14 tasks

Selecting another Signatory flow is not working #4247

jarias-lfx opened this issue Feb 16, 2024 · 13 comments
Assignees
Labels
01 - High High Priority bug Something isn't working CNCF CommunityReported

Comments

@jarias-lfx
Copy link

jarias-lfx commented Feb 16, 2024

Summary

Assigning another person as SIgnatory, the flow doesn't complete after the Signatory completes the signature.

Background

  1. Access CLA Corporate Console
  2. Start Signature process.
  3. When asked "" Are you authorized to sign the CLA for your organization", select No
  4. Add the Name and Email for the signatory person
  5. The page spins forever
  6. The signatory person receives a docusign email
  7. The signatory completes the signature
  8. Nothing happens

Expected behavior

After the signatory completes the signature the following must happen, but it doesn't after v2.0.150 release

  1. The CCLA gets updated in the signatures table. Marked as signed=true, docusing data, signatory date.
  2. The signed PDF gets uploaded to S3 bucket.
  3. The Initial CLA Manager receives an email with the signatory completion
  4. The initial CLA Manager gets the cla-manager role

Screenshots

Adding the Signatory person spins endlessly:

Image

Environment

Please complete the following information:

  • Environment:
    • ALL
    • DEV
    • STAGING
    • PROD
  • Browser:
    • [x ] Chrome/Brave
    • Firefox
    • Opera
    • Vivaldi
    • LibreWolf
    • SRware Iron
    • Dissenter
    • Slimjet
    • Midori
    • Edge
    • Lynx
@jarias-lfx jarias-lfx added bug Something isn't working 01 - High High Priority CommunityReported CNCF labels Feb 16, 2024
@thakurveerendras
Copy link
Contributor

Issue is working fine on dev site but on prod we are getting 500 server error for "RequestCorporateSignatureResult"

{
"data": {
"requestCorporateSignature": {
"code": 500,
"message": null,
"success": false,
"data": null,
"__typename": "RequestCorporateSignatureResult"
}
}
}

image

@sjparkinson
Copy link

Worth noting the Docusign is still sent to the recipient. I accidently sent it more than once as a result!

@mlehotskylf
Copy link
Contributor

@nickmango is looking into this.

@jarias-lfx
Copy link
Author

{
    "data": {
        "requestCorporateSignature": {
            "code": 500,
            "message": null,
            "success": false,
            "data": null,
            "__typename": "RequestCorporateSignatureResult"
        }
    }
}

nickmango added a commit to nickmango/easycla that referenced this issue Feb 21, 2024
- Resolved ccla request via email use case

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Feb 21, 2024
@nickmango
Copy link
Contributor

@thakurveerendras This has been resolved. Kindly verfiy

@thakurveerendras
Copy link
Contributor

@nickmango , The Issue is not reproducible as reported on the dev site, But after completing the signup easycla page is not loaded properly

  • Refer to the video clip:
4247.mp4

@nickmango
Copy link
Contributor

@thakurveerendras
The CCLA gets updated in the signatures table. Marked as signed=true, docusing data, signatory date.
The signed PDF gets uploaded to S3 bucket.
The Initial CLA Manager receives an email with the signatory completion
The initial CLA Manager gets the cla-manager role

Werent these expectations met ?

@thakurveerendras
Copy link
Contributor

Tested with the documents received at email but after signing the document, CCLAs remain not signed
Refer to the video clip:

4247_flow.mp4

image

@mlehotskylf
Copy link
Contributor

@nickmango is working on the fix.

@mlehotskylf
Copy link
Contributor

mlehotskylf commented Feb 26, 2024

"500 response" issue is resolved, now @nickmango is working on DocuSign callback issue as part of this ticket.

nickmango added a commit to nickmango/easycla that referenced this issue Feb 27, 2024
- Resolved issue for signatory signed callback

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Feb 27, 2024
@nickmango
Copy link
Contributor

@thakurveerendras kindly verify

nickmango added a commit to nickmango/easycla that referenced this issue Feb 27, 2024
- Added the right cla manager email post signing
- Associated SFcompany with the event

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Feb 27, 2024
@thakurveerendras
Copy link
Contributor

Tested this issue on the dev site at the parent & child project level and found that it is fixed as expected. So updating the issue status

4247.2.mp4

@thakurveerendras
Copy link
Contributor

Tested on the prod site and found that it is deployed properly. So moving issue status QA-Done
Refer to the video clip
4247_prod.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - High High Priority bug Something isn't working CNCF CommunityReported
Projects
None yet
Development

No branches or pull requests

6 participants