Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit: ICLAs & CCLAs Process stop at "You are being redirected to the login page." #4240

Closed
thakurveerendras opened this issue Feb 9, 2024 · 10 comments
Assignees
Labels
01 - High High Priority bug Something isn't working Gerrit An issue or feature related to Gerrit integration

Comments

@thakurveerendras
Copy link
Contributor

Summary

Gerrit: ICLAs & CCLAs Process stop at the "You are being redirected to the login page."

Background

Steps:

  1. Go to "https://gerrit.linuxfoundation.org/infra/settings/new-agreement" page
  2. Select the Gerrit project
  3. Click on "Please review the agreement." link
  4. See-"You are being redirected to the login page." open & keep loading

Expected behavior

User should redirect to docusigned page

Screenshots

image

@thakurveerendras thakurveerendras added the bug Something isn't working label Feb 9, 2024
nickmango added a commit to nickmango/easycla that referenced this issue Feb 10, 2024
- Resolved return url for the docusign flow

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Feb 10, 2024
@nickmango
Copy link
Collaborator

@thakurveerendras kindly check. As you had identified earlier there was an auth issue . You can check the docusign gerrit flow

@thakurveerendras
Copy link
Contributor Author

Tested issue on dev site and found that it is reproducible when we login with different user (lf user which having different Gerrit email address)

@thakurveerendras thakurveerendras added the 01 - High High Priority label Feb 12, 2024
@thakurveerendras thakurveerendras added the Gerrit An issue or feature related to Gerrit integration label Feb 12, 2024
@nickmango
Copy link
Collaborator

@thakurveerendras As confirmed with the production project JuanSebastian availed for testing... this is as well reproducible in prod and is not a regression issue
cc @mlehotskylf

@mlehotskylf
Copy link
Contributor

@amolsontakke3576 thank you for looking into this, please let us know what is the latest for this ticket. Thanks!

@mlehotskylf
Copy link
Contributor

mlehotskylf commented Feb 23, 2024

This is related to #3946 (it has the same root cause and once Auth0 is fixed then this ticket and #3946 get resolved automatically).

@mlehotskylf
Copy link
Contributor

This is fixed in DEV as reported. Moving to QA.

@jarias-lfx
Copy link

Confirmed the re-direction is working in Production for ICLA and CCLA. However, when the users perform an ICLA signature or proceed with ECLA for CCLA, the contributors should be added to the respective project LDAP group. This is currently not happening. Without this, even after signing, the users are unable to contribute, which is still a blocker.

nickmango added a commit that referenced this issue Mar 6, 2024
@nickmango
Copy link
Collaborator

@jarias-lfx resolved the ldap group addition however changes have been deployed in dev
cc @mlehotskylf

@mlehotskylf
Copy link
Contributor

We discovered that user was not added to LDAP. This is fixed and ready to deploy to PROD.

nickmango added a commit to nickmango/easycla that referenced this issue Mar 14, 2024
- Handled nil pointer execption for auth user
- Handled email send for icla
- Added ldap group for corporate callback

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Mar 14, 2024
[#4240] Bug/LDAP Gerrit LDAP group addition
@mlehotskylf
Copy link
Contributor

This is fixed and deployed to PROD so closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - High High Priority bug Something isn't working Gerrit An issue or feature related to Gerrit integration
Projects
None yet
Development

No branches or pull requests

5 participants