[#4472] Approval List search

- added case insensitive search for emails

Signed-off-by: Harold Wanyama <[email protected]>

cla-backend-go/signatures/service.go

@@ -1316,9 +1316,11 @@ func (s service) UserIsApproved(ctx context.Context, user *models.User, cclaSign
 	if len(emailApprovalList) > 0 {
 		for _, email := range emails {
 			log.WithFields(f).Debugf("checking email: %s", email)
-			if utils.StringInSlice(email, emailApprovalList) {
-				log.WithFields(f).Debugf("found matching email: %s in the email approval list", email)
-				return true, nil
+			// case insensitive search
+			for _, emailApproval := range emailApprovalList {
+				if strings.EqualFold(email, emailApproval) {
+					return true, nil
+				}
 			}
 		}
 	} else {

cla-backend-go/signatures/service_test.go

@@ -70,6 +70,16 @@ func TestUserIsApproved(t *testing.T) {
 			},
 			expectedIsApproved: true,
 		},
+		{
+			name: "Test user email case - email approval",
+			user: &v1Models.User{
+				Emails: []string{"[email protected]"},
+			},
+			cclaSignature: &v1Models.Signature{
+				EmailApprovalList: []string{"[email protected]"},
+			},
+			expectedIsApproved: true,
+		},
 	}
 
 	for _, tc := range testCases {