-
Notifications
You must be signed in to change notification settings - Fork 0
feat: upgrade postgres source to match 3.1.3 #2
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all these class files be checked in? Or should they built with gradle?
@@ -24,6 +24,8 @@ acceptance_tests: | |||
tests: | |||
- config_path: "secrets/config.json" | |||
- config_path: "secrets/config_cdc.json" | |||
backward_compatibility_tests_config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno
I literally have no idea what I am doing. I'll share a README with the steps I took to make this happen. Kelsey and I banged our heads on this for several hours yesterday so I don't know how much more time this deserves? |
I'm confused, how did this get built in the past? |
Can you say more about what is confusing you? I put the steps I took in the Readme. |
Converting this to draft for now - @KelseyNewman147 the image tagged 0.0.3 is good for you to test, but I am trying to update this to the latest-latest version and am hitting issues with airbyte-ci again, so probably just gonna rerun using airbyte 0.50.20 (which did work) and call it there, since I've already been on this for several hours... |
if by "all these class files" you mean things in the |
4. After the script finishes, you will receive the number of tables specified in the script, with names starting with **test_0** and ending with **test_(the number of tables minus 1)**. | ||
## Gradle what? | ||
|
||
It may surprise you to learn that in order to run `gradle` commands, you need to install `gradle`. Airbyte does not provide guidance on this, but you can start [here](https://gradle.org/install/) to install gradle, and also make sure you have the right Java SDK installed. As of writing, that would be Java SDK version 17 - you can see the latest in the build.gradle file of the airbyte repo ([here](https://github.com/airbytehq/airbyte/blob/master/build.gradle#L439-L442)). You might hit additional errors, and sadly you are on your own. Please take notes here if you make any useful discoveries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omg I was on the wrong version of Java 🤦♀️
This PR updates all the files in this repo to align with the postgres source connector that was current as of Airbyte v0.50.20, while preserving changes to spec.json and PostgresCdcProperties.java.
The most recent version of Airbyte (0.50.33) has some nonsense with
airbyte-ci
that isn't working for me when I try to build the source connector locally, so.... RIP that for now.This version of the CTA patch connector is available at
communitytechalliance/airbyte-source-postgres-patch:0.0.3
.I'll write up notes about how to build images for this (and other Java source connectors) in a separate PR, and probably also a Cacher runbook? cc @KelseyNewman147 @michaelefisher