Fix python autocomplete #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autocomplete returned list of attributes for non-existing members of a class. For example: `myobj.nonexisting.a` returned all the completions for `myobj.a`. Fixed by clearing the list of completions if a non-existing attribute is used. Also fixed the interpreter getting stuck in an error state after invalid autocomplete (or other Python errors). Fixed by always resetting the error state before command execution and after failed command executions.
Before this change, a strict alphabetical sorting was used, which means that order of attributes was: - uppercase letters: constants + internal classes + VTK methods - underscore: private attributes - lowercase letters: Python and Qt attributes and methods For example attributes of a Qt class: ``` AllowNestedDocks AllowTabbedDocks AnimatedDocks DockOption() ... PdmPhysicalDpiY PdmWidth PdmWidthMM RenderFlag() RenderFlags() VerticalTabs __bool__() __class__() __delattr__() __dict__ __dir__() __doc__ __eq__() __format__() ... __setattr__() __sizeof__() __str__() __subclasshook__() __weakref__ acceptDrops accessibleDescription accessibleName actionEvent() addToolBar() ... windowRole() windowState() windowTitle windowTitleChanged() windowType() x y ``` This means that the user must scroll through a lot of irrelevant parts before gets to method names. After this change, attributes are grouped into the following categories and displayed in this order: - Python and Qt attributes and methods (starts with lowercase letter) - VTK methods + static classes and types (starts with uppercase letter, ends with parenthesis) - constants (starts with uppercase letter, does not end with parenthesis) - private attributes (starts with underscore) Case insensitive comparison is used within each group. Example: ``` acceptDrops accessibleDescription accessibleName actionEvent() actions() activateWindow() addAction() ... windowType() winId() x y DockOption() DockOptions() PaintDeviceMetric() RenderFlag() RenderFlags() AllowNestedDocks AllowTabbedDocks AnimatedDocks DrawChildren ... PdmWidthMM VerticalTabs __bool__() __class__() __delattr__() ... __str__() __subclasshook__() __weakref__ ```
|
Since there are no objections and the changes are mostly trivial, I'll go on and merge this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect autocomplete in the Python console and improve ordering of attributes in the autocomplete list.