Fix Python console auto-completion #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes ctkPythonConsoleCompleter. The failure to check the value returned by PyObject_GetAttrString caused the error flag to be set and led to an inconsistent completer state. This was a problem only when built against Python3. Instead of explicitly checking the type of value returned by "PyObject_GetAttrString()", the function "PyErr_Print()" could have been called after the call to "PyObject_GetAttrString". This would have also cleared the internal error flag was not cleared and printed the following error: TypeError: bad argument type for built-in operation
jcfr
force-pushed
the
python3-fix-python-autocomplete
branch
from
5350a2c
to
5dc3396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.