Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update campaigns #18

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Update campaigns #18

merged 2 commits into from
Jul 10, 2020

Conversation

domdomegg
Copy link
Member

@domdomegg domdomegg commented Jul 8, 2020

Add Wikipedia Pages Wanting Photos, as per #17

- Remove Wiki Loves Africa (expired)
- Add Wikipedia Pages Wanting Photos, as per #17
@domdomegg
Copy link
Member Author

@sivaraam could you review please - leaving a comment is fine if you don't have direct access.

campaigns.json Outdated
"endDate": "2020-03-31",
"link": "https://commons.wikimedia.org/wiki/Commons:Wiki_Loves_Africa_2020"
"title": "Wikipedia Pages Wanting Photos",
"description": "Wikipedians add photos to Wikipedia articles lacking images",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be rephrase this to "Global campaign to add photos to Wikipedia articles that lack images."

Copy link
Member

@sivaraam sivaraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other the description suggestion, this looks good to me. 👍

Side note: I wonder if we should have a separate annual campaigns type for campaigns that happen on particular intervals of time. That way, we don't have to remove/add the campaigns each year. 🤔

@domdomegg
Copy link
Member Author

Other the description suggestion, this looks good to me.

Updated

Side note: I wonder if we should have a separate annual campaigns type for campaigns that happen on particular intervals of time. That way, we don't have to remove/add the campaigns each year.

That's a good point. I've actually undone the change to remove the other campaign so we'll have it there next year, and can update it when we have the new dates/theme etc.

Copy link
Member

@sivaraam sivaraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This can be merged now. 🚀

That's a good point. I've actually undone the change to remove the other campaign so we'll have it there next year, and can update it when we have the new dates/theme etc.

Makes sense. We can discuss about the annual campaigns type in a separate issue.

@sivaraam
Copy link
Member

sivaraam commented Jul 9, 2020

We can discuss about the annual campaigns type in a separate issue.

I've opened #19 for this.

@domdomegg domdomegg merged commit d18ff49 into master Jul 10, 2020
@domdomegg domdomegg deleted the wikipedia-pages-wanting-photos branch July 10, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants