Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show where file is being used on Commons & Other wikis #6006

Merged

Conversation

parneet-guraya
Copy link
Contributor

Fixes #4997

  • Show where the file is being used whether on Commons or Other wikis
  • Showing appropriate indications when loading pages for eg. showing loading indicator when loading & error message when there's an error.
  • Click on the item to open the page in browser.
  • Wiki style UI.

Screenshots (for UI changes only)

Record_2024-12-07-06-34-30.mp4

@parneet-guraya
Copy link
Contributor Author

Hi @nicolas-raoul , let me know if you want any changes :)

P.S: The huge changes are because I converted one of the file to .kt & I will fix conflicts eventually.

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Dec 7, 2024

UI looks great!
Is it still a draft?

@nicolas-raoul
Copy link
Member

If not a draft, please change status, so that CI can run. 🙂

@parneet-guraya parneet-guraya marked this pull request as ready for review December 7, 2024 09:23
@parneet-guraya
Copy link
Contributor Author

Hmm... CI still not running, maybe I have to solve merge conflicts first?

@nicolas-raoul
Copy link
Member

You are right, please fix the conflicts first, thanks! 🙂

@parneet-guraya parneet-guraya force-pushed the new-feature-file-usages branch from af6288b to d1b0b4d Compare December 7, 2024 21:10
app/build.gradle Outdated Show resolved Hide resolved
@parneet-guraya parneet-guraya force-pushed the new-feature-file-usages branch from afe267f to 5e3ab0a Compare December 8, 2024 02:44
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
@parneet-guraya parneet-guraya force-pushed the new-feature-file-usages branch from 5e3ab0a to 73b66d7 Compare December 8, 2024 22:34
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, usages shown for both minor and popular files.

@nicolas-raoul nicolas-raoul merged commit 85d9aef into commons-app:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show where a picture is in use
2 participants