Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #5841: Nearby pins: Make it easier to understand what the colors mean #5881

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

hannagnourt
Copy link
Contributor

Description (required)

Fixes #5841

  1. Add a legend to explain the meaning of the colors of nearby pins
  2. Add a floating action button to toggle the visibility (show/hide) of the legend

Tests performed (required)

Tested prodDebug on Pixel 8 Pro with API level 35.

Screenshots (for UI changes only)

nearby_legend.mp4

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! I just noted a few minor things, then it should be good to merge.

app/src/main/res/layout/nearby_legend.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/nearby_legend.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/nearby_legend.xml Outdated Show resolved Hide resolved
@hannagnourt
Copy link
Contributor Author

Looks fantastic! I just noted a few minor things, then it should be good to merge.

Thank you! We will make these changes by today.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great and elegant code.
Thanks for your contribution! :-)

@nicolas-raoul nicolas-raoul merged commit ba7348f into commons-app:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nearby pins: Make it easier to understand what the colors mean
2 participants