Use new result API

[parneet-guraya]

Fixes #5849

What changes did you make and why?

• Migrate Activities that are launched with expectancy of getting result back, to new result api.

For ease of review, these are the functionalities that are affected and have been tested.

• File picking -> Camera, Gallery, Custom; from every place one or more of these options can be used have been refactored.
• getting result back from ImageFragment launched from CustomSelectorActivity
• getting result of voice input.
• result from image editing from EditActivity

Tests performed (required)
betaDebug & prodDebug tested on Oneplust 9RT 5G , Android 14

[nicolas-raoul]

I have tested the features you mentioned, they seem to be working great on Pixel 9 too. :-)
I will try some uploads tomorrow.

Meanwhile, I noticed a few places missing a comma after , would you mind fixing them?

Thanks a lot!

[parneet-guraya]

Meanwhile, I noticed a few places missing a comma after , would you mind fixing them?

I'm not quite sure what you meant by that, are you talking about adding a space just after the comma?

Also, I know it needs reformatting, I tried it but it also reformats the code which isn't part of the my change (maybe somebody missed reformatting previously) that's why I manually did reformatting and might have missed some places. However, if you say I can reformat all the affected files just know that it will also include the change which I didn't make.

[parneet-guraya]

Also what do we use for updating branches? I saw you used merge, but I was using rebase until now. Do we follow any standard?

[nicolas-raoul]

I tested more today, it is working great, I will merge once the commas are fixed. :-)

adding a space just after the comma

Yes, for instance initiateCameraUpload(activity,resultLauncher); should be initiateCameraUpload(activity, resultLauncher);

Merge and rebase are fine, the whole pull request is eventually squashed into a single commit at the end anyway. :-)

[parneet-guraya]

Added requested changes b68256d

[nicolas-raoul]

Great work, thanks!