Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https scheme #751

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Use https scheme #751

merged 8 commits into from
Oct 25, 2023

Conversation

muzimuzhi
Copy link
Contributor

Convert http to https scheme for all links in the repo, including examples in spec.txt (not sure if welcome).

The remaining http schemes are

  • a link to www.aaronsw.com in spec.txt because it doesn't support https,
  • all links in changelog.txt because I assume released changelog entries should be kept as-is, and
  • a link in CommonMark.dtd because I know nothing about .dtd file format.
# need GNU grep to use option "-P"
grep --color=auto --exclude-dir=.git -rnP '(?<!/)http://' .
./spec.txt:1142:[original ATX implementation](http://www.aaronsw.com/2002/atx/atx.py),
./changelog.txt:311:    Discussion at <http://talk.commonmark.org/t/555>.
./changelog.txt:314:    Discussion at <http://talk.commonmark.org/t/779> and
./changelog.txt:315:    <http://talk.commonmark.org/t/1287/12>.
./changelog.txt:346:    See http://talk.commonmark.org/t/horizontal-rule-or-thematic-break/912/3
./changelog.txt:503:    <http://talk.commonmark.org/t/odd-list-behaviour/1189>).
./changelog.txt:624:    <http://talk.commonmark.org/t/903/6>. The basic idea of the change
./CommonMark.dtd:10:    xmlns CDATA #FIXED "http://commonmark.org/xml/1.0">

Copy link
Contributor

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be nice to still have one test that uses http:. Otherwise looks good

@muzimuzhi
Copy link
Contributor Author

@wooorm Now example 593, the example right after doc for scheme, uses both http and https.

@jgm
Copy link
Member

jgm commented Oct 25, 2023

I would suggest just using http in that example -- after all, the next example uses https.

@muzimuzhi
Copy link
Contributor Author

I'm a little worried that using http solely in a single example might look like it's missed from a http->https substitution.

after all, the next example uses https.

Ok, I'm convinced.

@jgm jgm merged commit 2a026ec into commonmark:master Oct 25, 2023
@muzimuzhi muzimuzhi deleted the use-https-scheme branch October 26, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants