-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https scheme #751
Use https scheme #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be nice to still have one test that uses http:
. Otherwise looks good
New link is already used on https://commonmark.org/, and the old link http://try.commonmark.org/ doesn't seem to support https scheme.
Link to www.aaronsw.com leaves intact because it doesn't support HTTPS.
@wooorm Now example 593, the example right after doc for scheme, uses both http and https. |
I would suggest just using http in that example -- after all, the next example uses https. |
I'm a little worried that using http solely in a single example might look like it's missed from a http->https substitution.
Ok, I'm convinced. |
Convert http to https scheme for all links in the repo, including examples in
spec.txt
(not sure if welcome).The remaining http schemes are
www.aaronsw.com
inspec.txt
because it doesn't support https,changelog.txt
because I assume released changelog entries should be kept as-is, andCommonMark.dtd
because I know nothing about.dtd
file format.