Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistakes at description of 'HTML blocks' #578

Closed
wants to merge 1 commit into from
Closed

Fix mistakes at description of 'HTML blocks' #578

wants to merge 1 commit into from

Conversation

vanou
Copy link

@vanou vanou commented Apr 27, 2019

  • Fix mistakes
    Three inline link texts 'end condition' with no link destination

   Three inline link texts 'end condition' with no link destination
@jgm
Copy link
Member

jgm commented Apr 28, 2019

What's the mistake? [end condition](@) defines an anchor and should occur only once. The other links will work automatically.

Note: this is NOT a standalone commonmark file. It is in a special format which is designed to be processed using tools/make_spec.lua.

@jgm jgm closed this Apr 28, 2019
@vanou
Copy link
Author

vanou commented Apr 29, 2019

@jgm

Note: this is NOT a standalone commonmark file. It is in a special format which is designed to be processed using tools/make_spec.lua.

Thanks. I understand.

I wanted to fix link break in this PR.
See HTML blocks, because end condition is referenced as https://spec.commonmark.org/0.29/#end , other shortcut reference links [end condigion] get break.

Any way this PR is wrong one. Thanks.

@jgm
Copy link
Member

jgm commented Apr 29, 2019

Yes, you're right -- that's a legitimate bug! I just didn't see what it was from your PR.

jgm added a commit that referenced this pull request Apr 29, 2019
Previously it broke in a few cases, e.g. with soft breaks.

This fixes the issue described in #578.
@jgm
Copy link
Member

jgm commented Apr 29, 2019

I've fixed this in master by fixing the program that generates the HTML from spec.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants