Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new entity length constraints #575

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Conversation

MihaZupan
Copy link
Contributor

This now tests that an entity with 8 arabic digits is no longer recognised

This now tests that an entity with 8 arabic digits is no longer recognised
@jgm jgm merged commit 026ca82 into commonmark:master Apr 11, 2019
@MihaZupan MihaZupan deleted the patch-1 branch April 11, 2019 18:51
@mity
Copy link

mity commented May 16, 2019

Maybe the limit for the hexadecimal variant should then be tested too.

@MihaZupan
Copy link
Contributor Author

The new limit for hexadecimals is tested by example 314

@mity
Copy link

mity commented May 16, 2019

No, it is not.

&#abcdef0; does not contain the x.

@MihaZupan
Copy link
Contributor Author

Ah, mb.

Looks like commonmark.js does not take the new length limit into account
babelmark

@jgm
Copy link
Member

jgm commented May 16, 2019

babelmark III is running an old version (0.28.1).
Try https://johnmacfarlane.net/babelmark2/?normalize=1&text=lid+%26%23xabcdef%3B%0A%0ANot+valid+%26%23xabcdef0%3B%0A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants