Fix dingus link when double clicking Markdown code #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the link opened is always `/dingus/?text=` (no text), because `$(this)` is `code.language-markdown`, so `.find`ing `code` in its descendants turns up nothing.
|
Thanks! BTW, it worked fine before in my browser, but I'll take your word for it that it didn't work in yours. |
|
Hmm, weird, I tested in latest Chrome (69.0.3497.100), Firefox (63.0b10) and Safari (12.1) and none of them worked. |
|
Odd. It worked fine on latest Safari for me.
Zhiming Wang <[email protected]> writes:
… Hmm, weird, I tested in latest Chrome (69.0.3497.100), Firefox (63.0b10) and Safari (12.1) and none of them worked.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, double clicking on Markdown code on https://spec.commonmark.org/0.28/ always opens https://spec.commonmark.org/dingus/?text= without content prefill. This PR fixes that bug.