Replace image 'url' with 'destination' in DTD #512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DTD defines a 'url' attribute for an image, however both cmark and CommonMark.js appear to use 'destination' instead (which is also consistent with a link).
http://spec.commonmark.org/dingus/
This MR updates the DTD to use 'destination' instead of 'url'. I couldn't see any other references in the spec indicating which attribute is actually correct, but if it is the case that cmark/commonmark.js are actually incorrect and not following the DTD, please close this.