Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention removing surrounding whitespace from link labels #479

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Jun 3, 2017

According to the JS reference implementation, these are matching link labels, although one is surrounded by spaces:

[ a ]: b

[a]

On a related note: It is not quite clear if the brackets themselves are part of the link label or not.

A link label begins with a left bracket ([) and ends with the first right bracket (]) that is not backslash-escaped.

The words "begin" and "end" sound like the brackets are included.
However, that can't be, because it's not allowed:

Unescaped square bracket characters are not allowed in link labels.

If the brackets are part of the link label, the word internal whitespace doesn't quite mean what it's supposed to mean.

My English-fu isn't good enough to suggest an improvement in wording.

@jgm jgm merged commit f09a977 into commonmark:master Aug 1, 2017
jgm added a commit that referenced this pull request Aug 1, 2017
Say explicitly that normalization involves stripping off
leading and trailing bracket characters, before stripping
leading and trailing whitespace.

See #479.
@mgeier mgeier deleted the strip-whitespace-from-link-labels branch August 2, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants