Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaped backslash at end of link label #325

Closed
BigBadaboom opened this issue May 14, 2015 · 4 comments
Closed

Escaped backslash at end of link label #325

BigBadaboom opened this issue May 14, 2015 · 4 comments

Comments

@BigBadaboom
Copy link

If I am reading the spec right, the following sample should be a valid link label shouldn't it?

[bar\\]: /url "title"

[bar\\]

http://spec.commonmark.org/dingus/?text=%5Bbar%5C%5C%5D%3A%20%2Furl%20%22title%22%0A%0A%5Bbar%5C%5C%5D%0A

However commonmark.js is not recognising it as such, and is instead generating a paragraph.
@jgm
Copy link
Member

jgm commented May 14, 2015

Yes, this is a bug. (cmark does the right thing here.)
Thanks for reporting.

@jgm
Copy link
Member

jgm commented May 14, 2015

Could you open an issue on jgm/commonmark.js instead of here?

@BigBadaboom
Copy link
Author

Done.

commonmark/commonmark.js#38

Sorry, I didn't realise there was a separate repo.

@jgm jgm closed this as completed Jun 4, 2015
@jgm jgm reopened this Jun 13, 2015
@jgm
Copy link
Member

jgm commented Jun 13, 2015

Re-opening. This has been fixed in commonmark.js, but it would be good to have a test case for this in the spec.

colinodell added a commit to thephpleague/commonmark that referenced this issue Jun 20, 2015
@colinodell
Allow backslash-escaped backslashes in link labels (#119)
eca16cc 
See also:

 - commonmark/commonmark.js#38
 - commonmark/commonmark-spec#325
 - commonmark/commonmark.js@b21e975
@jgm jgm closed this as completed in 60a0a7a Dec 29, 2015
@ScottAbbey ScottAbbey mentioned this issue Apr 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgm @BigBadaboom