Fix tables with leading/trailing header pipes and trailing spaces #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another table rendering issue introduced in 0.16.1. It's extremely obscure (found by running 0.18.0 against millions of markdown comments and comparing against 0.15.2) but I'm hoping the fix is simple enough that we can maintain compatibility with 0.15.2. 🤞
It's probably easiest to look at the added test cases - note the space at the end of the header line in the first test. When the header row has leading/trailing pipes and the trailing pipe is followed by whitespace, the table fails to render. (Trailing whitespace on the separator line or content lines works fine; trailing whitespace when the header line doesn't have a trailing pipe also works fine)
The 0.15.2 code would trim each line at the start of
split()
. Without the trim,split()
adds the whitespace after the trailing pipe as another header cell. As a result,tryStart
thinks there are more header cells than columns and stops trying to parse a table.The current code already removes any leading whitespace and any leading pipe. If and only if there's a leading pipe, the fix does the same for the trailing pipe.