Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v3 #712

Merged
merged 21 commits into from
Apr 23, 2023
Merged

Release/v3 #712

merged 21 commits into from
Apr 23, 2023

Conversation

woile
Copy link
Member

@woile woile commented Apr 19, 2023

Description

Preparing commitizen for v3.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.50 ⚠️

Comparison is base (89978e1) 97.87% compared to head (28ac04f) 97.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3     #712      +/-   ##
==========================================
- Coverage   97.87%   97.37%   -0.50%     
==========================================
  Files          42       42              
  Lines        1928     2019      +91     
==========================================
+ Hits         1887     1966      +79     
- Misses         41       53      +12     
Flag Coverage Δ
unittests 97.37% <83.33%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/version_types.py 90.74% <ø> (ø)
commitizen/commands/init.py 87.43% <83.33%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woile woile requested a review from Lee-W April 20, 2023 15:21
@woile woile force-pushed the release/v3 branch 6 times, most recently from f9d110c to f26e3c1 Compare April 21, 2023 08:58
commitizen/defaults.py Outdated Show resolved Hide resolved
commitizen/commands/init.py Outdated Show resolved Hide resolved
commitizen/commands/init.py Outdated Show resolved Hide resolved
commitizen/commands/init.py Show resolved Hide resolved
commitizen/commands/init.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
scripts/format Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I left a few minor comments and suggests, but I'm good even if they're not addressed.

commitizen/commands/init.py Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved

Default: `false`

Update changelog with the missing versions. This is good if you don't want to replace previous versions in the file. Note: when doing `cz bump --changelog` this is automatically set to `true`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be a bit confusing as the default behavior for cz bump --changelog and cz changelog are different?

Copy link
Member Author

@woile woile Apr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has always been the case. cz bump --changelog avoids messing with your changelog (this allows users to modify further the file). With cz changelog the whole file will be recreated. An alternative would be to set changelog_incremental as default = True. This way cz bump --changelog and cz changelog would behave the same. But it's another breaking change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like changelog_incremental=True as default a bit more, but would be ok if we keep it as it is

docs/init.md Outdated Show resolved Hide resolved
@woile woile merged commit 941abf0 into v3 Apr 23, 2023
@woile woile deleted the release/v3 branch April 23, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants