-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#426): system info utility #427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 97.90% 97.91% +0.01%
==========================================
Files 39 39
Lines 1384 1392 +8
==========================================
+ Hits 1355 1363 +8
Misses 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
looks like the behavior of argparse has been changed on python 3.9. let me see how I can solve it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarthaksharma2199 , thanks for the immediate PR! I'm good with the --report
flag. @woile what do you think?
One thing to note is that we'll need to wait for #430 to be merged. As a new fix on Python 3.9.7 breaks our unit test
Looks good to me, thank you! 🙏🏻 |
fbbd552
to
7d5b80e
Compare
command to show system info output for bug reports Issue commitizen-tools#426
ff822f2
to
f8e2224
Compare
It looks great! Thanks! Let's merge it |
command to show system info output for bug reports
Issue #426
Description
As mentioned in issue #426 , a single line command would be preferable to fetch system information
I added a
--report
flag to theversion
command for doing that.Checklist
./script/format
and./script/test
locally to ensure this change passes linter check and testExpected behavior
System info can be output using a single command which can be attached to bug report
Steps to Test This Pull Request
Additional context