Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct indentation for json config for better readability #394

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

woile
Copy link
Member

@woile woile commented Jun 23, 2021

Description

Output the json config as multi line instead of single-line.
This is much more readable.

Checklist

  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually

Expected behavior

Output should look like this:

{
  "commitizen": {
    "name": "cz_conventional_commits",
    "version": "0.0.1",
    "tag_format": "$version"
  }
}

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #394 (986f2d8) into master (00f81d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          39       39           
  Lines        1381     1381           
=======================================
  Hits         1352     1352           
  Misses         29       29           
Flag Coverage Δ
unittests 97.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/config/json_config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc22f2e...986f2d8. Read the comment docs.

@woile woile merged commit a958ed4 into master Jun 24, 2021
@woile woile deleted the fix/json-indent branch June 24, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant