Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for jinja2 v3 #392

Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix: add support for jinja2 v3 #392

merged 1 commit into from
Jun 22, 2021

Conversation

woile
Copy link
Member

@woile woile commented Jun 21, 2021

Closes #391

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually

Expected behavior

Steps to Test This Pull Request

Additional context

@woile woile requested a review from Lee-W June 21, 2021 17:16
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #392 (00f81d3) into master (d82727c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          39       39           
  Lines        1381     1381           
=======================================
  Hits         1352     1352           
  Misses         29       29           
Flag Coverage Δ
unittests 97.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7573d16...00f81d3. Read the comment docs.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woile woile merged commit f2272bd into master Jun 22, 2021
@woile woile deleted the fix/391-jinja-support branch June 22, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Update commitizen to support Jinja2's latest version for flaskv2.
2 participants