Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle commiting when no file change #45

Closed
Lee-W opened this issue Nov 8, 2019 · 3 comments
Closed

handle commiting when no file change #45

Lee-W opened this issue Nov 8, 2019 · 3 comments

Comments

@Lee-W
Copy link
Member

Lee-W commented Nov 8, 2019

In cz-cli, if we run git cz without any file change, we'll get the message "No files added to staging! Did you forget to run git add?".

However, in cz c, we can still run the whole process.
The git commit is not actually created.

Screen Shot 2019-11-08 at 5 53 05 PM

Maybe we can detect file change like cz-cli? Or, at least we could let the user know that this commit is not actually created.

@woile
Copy link
Member

woile commented Nov 8, 2019 via email

@Lee-W
Copy link
Member Author

Lee-W commented Nov 8, 2019

I would suggest do it before because in such situation all the actions after that are meaningless.

@woile
Copy link
Member

woile commented Nov 8, 2019

Agreed, I had that very same issues a few minutes ago haha. Feel free to create a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants