-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle commiting when no file change #45
Comments
I like the idea. I'm not sure whether we should do it before or after the
prompted questions. What would you suggest?
…On Fri, Nov 8, 2019, 10:57 Wei Lee ***@***.***> wrote:
In cz-cli <https://github.com/commitizen/cz-cli>, if we run git cz
without any file change, we'll get the message "No files added to staging!
Did you forget to run git add?".
However, in cz c, we can still run the whole process.
The git commit is not actually created.
[image: Screen Shot 2019-11-08 at 5 53 05 PM]
<https://user-images.githubusercontent.com/5144808/68467190-ba08ce80-0250-11ea-9d0e-f617d9e25eed.png>
Maybe we can detect file change like cz-cli? Or, at least we could let the
user know that this commit is not actually created.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#45>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATXJWAY4FQ6HIUWWZ7RJDTQSUZY5ANCNFSM4JKVBOKA>
.
|
I would suggest do it before because in such situation all the actions after that are meaningless. |
Agreed, I had that very same issues a few minutes ago haha. Feel free to create a PR to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In cz-cli, if we run
git cz
without any file change, we'll get the message "No files added to staging! Did you forget to run git add?".However, in
cz c
, we can still run the whole process.The git commit is not actually created.
Maybe we can detect file change like cz-cli? Or, at least we could let the user know that this commit is not actually created.
The text was updated successfully, but these errors were encountered: