re-enable hledger-web tests / troubleshoot terminfo error

[simonmichael]

Trying to reproduce terminfo-related error when running tests. simonmichael/hledger#2157

[juhp]

Do you want me to apply this or should we convert it to a draft?

[simonmichael]

Do you want me to apply this or should we convert it to a draft?

I'd be happy to see the result, but I'm assuming it'll show you the same setupTerm unknown error you saw before. Really I was just trying to reproduce that, and now I see this is not the way. So I guess I'll make this a draft.

I believe reproducing it requires running the curator tool and building all of stackage (?) which might be a bit much for me (or not ?) Is there a log you can point me to where I can see the error message and maybe suggest some extra debug logging ?

[simonmichael]

Here are some notes gathered from the related simonmichael/hledger#2157 and from #haskell-stack:matrix.org.

What is failing ?

Something is giving an error similar to setupTerm: Couldn't look up terminfo entry "unknown" when building or running hledger-web's test suite. See this comment.

What could explain hledger-web's test suite, and only hledger-web's, failing with a terminal-related error ?

• Most hledger packages import from transitively, even if they don't use, these three terminal-related packages: ansi-terminal, terminal-size, terminfo.
• Test runners also interact with the terminal.
• hledger-ui doesn't have a test suite and hledger-lib's test suite is currently disabled in stackage. Among the hledger packages, that leaves hledger and hledger-web.
• Among the hledger packages, hledger-web's test suite is the only one using hspec.
• Among all stackage nightly packages, hledger-web and sydtest-yesod are the only ones using yesod-test. (sydtest-yesod's test suite is also disabled, for a different reason.)

More notes

• I guessed
  https://github.com/commercialhaskell/stackage/actions/workflows/image.yml
  might be the workflow that runs curator build and is failing to run
  hledger-web tests.. but I don't see any failures for it.
• I am guessing https://github.com/commercialhaskell/curator/blob/master/app-curator/Main.hs#L273
  might be where curator tries to build/run those tests and fails.
• I wonder what the stack --terminal flag does, it seems undocumented (and didn't affect the build on my machine).
• I wonder if the docker image being used to run curator needs
  terminfo or libtinfo-dev installed, eg in
  https://github.com/commercialhaskell/stackage/blob/master/docker/02-apt-get-install.sh ?

[juhp]

It is possible we should update from libncurses5-dev to libncurses-dev (v6)?
Though the former also ought to still work..

[juhp]

It is possible we should update from libncurses5-dev to libncurses-dev (v6)? Though the former also ought to still work..

I made this change now so future nightly snapshots should have "libtinfo6-dev" in line with ghc-tinfo6 bindists.
So let's hope that helps and doesn't break current stackage binary build output too much ;-)

[simonmichael]

Thanks! 🤞🏻 I have undrafted this PR so feel free to merge when it's ready to re-test.

[simonmichael]

PS is libncurses5-dev equivalent to terminfo or libtinfo-dev ? I'm not sure. I know at least the last one fixes certain builds on certain ubuntu versions.

[juhp]

https://packages.ubuntu.com/search?keywords=libtinfo-dev

(libtinfo is a library provided by ncurses)

[ysangkok]

I disabled hledger-web in #7421 because wai-handler-launch isn't updated to warp-3.4 yet. But I've made a PR for that:

• Allow newer dependencies yesodweb/wai-handlers#5

[simonmichael]

Unfortunately the situation remains unchanged

Thanks for trying, @juhp & @alaendle. I'm not too docker-equipped and not able to troubleshoot the curator's environment further myself; so while I'd prefer not to need special handling for hledger-web in stackage, I'll leave the tests disabled for now.