Trim transitive tracing dependencies #5289
Conversation
Most of the previous entries are not needed anymore. `ip` is the only one which isn't already transitively depended on (I kept it and moved it under its owner). For reference, here is the full list of dependencies $ stack ls dependencies --no-include-base --test HUnit 1.6.0.0 QuickCheck 2.13.1 aeson 1.4.3.0 ansi-terminal 0.9.1 async 2.2.2 attoparsec 0.13.2.2 base-compat 0.10.5 base16-bytestring 0.1.1.6 basement 0.0.10 binary 0.8.6.0 blaze-builder 0.4.1.0 bytestring 0.10.8.2 case-insensitive 1.2.0.11 containers 0.6.0.1 cookie 0.4.4 deepseq 1.4.4.0 directory 1.3.3.0 dlist 0.8.0.6 exceptions 0.10.2 ghc-prim 0.5.3 hashable 1.2.7.0 hspec 2.7.1 hspec-core 2.7.1 hspec-discover 2.7.1 hspec-expectations 0.8.2 http-client 0.6.4 http-types 0.12.3 integer-gmp 1.0.2.0 integer-logarithms 1.0.3 ip 1.5.0 memory 0.14.18 mime-types 0.1.0.9 mtl 2.2.2 network 2.8.0.1 network-uri 2.6.1.0 parsec 3.1.13.0 pretty 1.1.3.6 primitive 0.6.4.0 process 1.6.5.0 quickcheck-io 0.2.0 random 1.1 rts 1.0 scientific 0.3.6.2 setenv 0.1.1.3 splitmix 0.0.2 stm 2.5.0.0 streaming-commons 0.2.1.1 tagged 0.8.6 template-haskell 2.14.0.0 text 1.2.3.1 tf-random 0.5 th-abstraction 0.3.1.0 time 1.8.0.2 time-locale-compat 0.1.1.5 tracing 0.0.4.1 transformers-compat 0.6.5 unix 2.7.2.2 unliftio 0.2.11 unliftio-core 0.1.2.0 unordered-containers 0.2.10.0 uuid-types 1.0.3 vector 0.12.0.3 wide-word 0.1.0.8 zlib 0.6.2 Note that it contains a few entries which are transitive dependencies of packages which are already in the build constraints. For example: * binary < scientific * deepseq < bytestring * integer-gmp < integer-logarithms * process < unliftio * stm < streaming-commons
|
The build failed, it looks like those transitive dependencies still apply. Also, we don't typically allow people to add packages under the maintenance headlines of someone else. |
|
Thanks for taking a look. I think what happened is that I've removed |
|
It looks like the only other two maintainers affected by this are @athanclark, since attoparsec-ip and attoparsec-uri both depend on ip, and @nikita-volkov, since stm-hamt depends on primitive-extras. Are the two of you interested in taking over maintainership of the transitive dependencies of the relevant packages? If not, the curator team will have to decide to either:
|
|
I'm not sure what is requested of me here. Neither stm-hamt or primitive-extras depend on the "ip" package. |
|
Hello, sorry for being late to the conversation. I'm not exactly sure what is being asked, but I originally made attoparsec-ip to be compliant with the ip package; if it's causing issues transitively, I could pretty quickly pop-and-swap an in-package data type, because the parser is independent from the rest of the ip package. Would that be ideal for my end? Or if a maintainer for ip is being requested, I could lend a hand, but I'm not sure if I understood the issue properly. |
|
Sorry for the lack of clarity. Let me see if I get this right:
So the options here are:
My preference is for (2). Does that clarify? |
|
I'm up for any option that lets me avoid maintenance of packages which I'm not the author of. |
|
I decided to remove the packages attoparsec-ip and attoparsec-uri entirely; attoparsec-ip just relies on the parsers provided by ip. Referenced by #5300 |
|
Please see #5307 |
|
Fantastic - thanks @snoyberg! |
Drop tracing transitive deps #5289
Most of the previous entries are not needed (anymore? - I'm not sure why they had been added).
ipis the only dependency which isn't already referenced; it is now in @andrewthad's section (author of the library).I noticed this while investigating a fix for this issue, which requires an update to
small-bytearray-builderwhich I don't own and AFAICT isn't used bytracing. For reference, here is the list oftracing's transitive dependencies: