Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettyprinter-compat-annotated-wl-pprint #5779

Closed
alexeyzab opened this issue Dec 8, 2020 · 4 comments
Closed

prettyprinter-compat-annotated-wl-pprint #5779

alexeyzab opened this issue Dec 8, 2020 · 4 comments

Comments

@alexeyzab
Copy link
Contributor

    Configuring prettyprinter-compat-annotated-wl-pprint-1...
    Preprocessing library for prettyprinter-compat-annotated-wl-pprint-1..
    Building library for prettyprinter-compat-annotated-wl-pprint-1..
    [1 of 1] Compiling Text.PrettyPrint.Annotated.Leijen

    /var/stackage/work/unpack-dir/unpacked/prettyprinter-compat-annotated-wl-pprint-1-7d52ae08d685ad0f1e55fb5cfe22acc35c10c0cdb5ed4a82ce5f9cd93a5a1539/src/Text/PrettyPrint/Annotated/Leijen.hs:34:1: error:
        Could not find module ‘Data.Text.Prettyprint.Doc.Render.ShowS’
        Perhaps you meant
          Data.Text.Prettyprint.Doc.Render.String (from prettyprinter-1.7.0)
          Data.Text.Prettyprint.Doc.Render.Text (from prettyprinter-1.7.0)
          Data.Text.Prettyprint.Doc.Render.Terminal (needs flag -package-key prettyprinter-ansi-terminal-1.1.2)
        Use -v (or `:set -v` in ghci) to see a list of the files searched for.
       |
    34 | import qualified Data.Text.Prettyprint.Doc.Render.ShowS      as New
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

cc @sjakobi, related to allowing prettyprinter 1.7.0 in a recent PR it looks like: #5775

@simonmichael
Copy link
Contributor

simonmichael commented Dec 14, 2020

Hi @alexeyzab! You quietly reverted my #5775 which was closing a number of issues. I would be glad of a notification next time; it's a fair bit of work trying to keep software in stackage nightly.

You did this to keep prettyprinter-compat-annotated-wl-pprint in stackage, but it seems like a minor package (not listed at https://packdeps.haskellers.com/reverse). What is it used for ? If I'm not misjudging it's importance, I think it should be removed from stackage until it is updated, instead.

@sjakobi
Copy link
Member

sjakobi commented Dec 14, 2020

I – as a (co-)maintainer of prettyprinter-compat-annotated-wl-pprint – agree that this package isn't important enough that it would warrant holding back more important packages like prettyprinter or pretty-simple.

In general, I'd appreciate if incompatible packages were removed more aggressively from Stackage Nightly, when this would help avoid bounds on more central packages. I think this would generally help speed up the resolution of incompatibilities in the ecosystem.

@simonmichael
Copy link
Contributor

simonmichael commented Dec 16, 2020

I'll go ahead and remove prettyprinter-compat-annotated-wl-pprint for now and restore latest prettyprinter, pretty-simple and hledger, if there are no objections.

[#5785]

simonmichael added a commit to simonmichael/stackage that referenced this issue Dec 16, 2020
@DanBurton
Copy link
Contributor

merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants