Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary-tagged, remove WithTag #954

Merged
merged 3 commits into from
Sep 8, 2015

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Sep 8, 2015

I tried to use the old stack and one with this patch one after each other, both pruned other's caches.

Fixes #889

@snoyberg
Copy link
Contributor

snoyberg commented Sep 8, 2015

That was a lot faster than I was expecting, thanks! This looks good to merge, just waiting for Travis. Could you also add something to the ChangeLog about this?

@phadej
Copy link
Collaborator Author

phadej commented Sep 8, 2015

Indeed, it was quite straightforward change.

@phadej
Copy link
Collaborator Author

phadej commented Sep 8, 2015

And for the record: binary-tagged will catch changes like https://github.com/commercialhaskell/stack/pull/902/files#diff-8c2944535368646d36cd90e08a658087R74 so one doesn't need to manually bump SemanticVersion.

snoyberg added a commit that referenced this pull request Sep 8, 2015
Use binary-tagged, remove WithTag
@snoyberg snoyberg merged commit 76716b3 into commercialhaskell:master Sep 8, 2015
@snoyberg
Copy link
Contributor

snoyberg commented Sep 8, 2015

Thanks!

@phadej phadej deleted the 889-binary-tagged branch September 8, 2015 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants