Use exact GHC versions rather than major-version #736 #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsloan
force-pushed
the
736-exact-ghc-versions
branch
2 times, most recently
from
acbbdde to
66d990a
Compare
* Stack now defaults to matching the minor version specified in the resolver / snapshot, whereas before only the major version was significant. * Adds a 'compiler-check' field which specifies a policy for checking the GHC version. * Changes the format of stack-setup.yaml, and so changes which URL is used to find it (in order to not break old stack versions). * Refactors ensureTool code, as it already had a lot of special cases, which I found confusing. Main cause is that I needed to pass in a 'CompilerVersion' instead of 'Version', but just for installing ghc, not for git. * Introduces a 'CompilerVersion' type, and changes some naming to specify that compiler versions are being passed around rather than ghc versions. The change could be a simpler without this, but this will be helpful for GHCJS support.
mgsloan
force-pushed
the
736-exact-ghc-versions
branch
from
66d990a to
fcedab0
Compare
| @@ -735,7 +735,7 @@ data CustomSnapshot = CustomSnapshot | |||
| instance FromJSON CustomSnapshot where | |||
| parseJSON = withObject "CustomSnapshot" $ \o -> CustomSnapshot | |||
| <$> ((o .: "compiler") >>= (\t -> maybe (fail $ "Invalid compiler: " ++ T.unpack t) return $ do | |||
| t' <- T.stripPrefix "ghc-" t | |||
| parseVersionFromString $ T.unpack t')) | |||
| GhcVersion v <- parseCompilerVersion t | |||
There was a problem hiding this comment.
Probably shouldn't use this kind of match, as the compiler will hide the incomplete pattern match, and you're about to add more constructors (I presume).
There was a problem hiding this comment.
I'll make the change myself, it will also give me a chance to compile/test it locally.
…ore constructors added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test before commercialhaskell/stackage-content#8 is merged, replace this line with
Description from the commit:
supports them. They resolve to the newest installed / available ghc
matching that number.
used to find it (in order to not break old stack versions).
which I found confusing. Main cause is that I needed to pass in a
'CompilerVersion' instead of 'Version', but just for installing ghc,
not for git.
specify that compiler versions are being passed around rather than ghc
versions. The change could be a simpler without this, but this will
be helpful for GHCJS support.