Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow building with Stackage lts-21 #6165

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

juhp
Copy link
Contributor

@juhp juhp commented Jun 21, 2023

Fixes #6159

I tested by building locally with ghc-9.4 stackage nightly (before lts-21.0 was released)

@mpilgrem
Copy link
Member

mpilgrem commented Jun 21, 2023

@juhp, thanks. The linting is failing because of the duplicated LANGUAGE CPP in Stack.Docker. I think it does not build on Windows because there is no macro MIN_VERSION_unix(0,7,0) because there is no unix package; that macro may need to be guarded with more CPP to test for non-Windows.

I am not sure what is causing the Linux integration tests to fail so early. I've re-run it, in case it was a glitch somewhere. EDIT: That job passed when re-run, so it must have been a glitch.

@mpilgrem
Copy link
Member

mpilgrem commented Jun 22, 2023

On unix-compat, I think the solution is to back-port to Stack 2.9.3.1 the fix in 6c85911. EDIT: The background to that commit is at: #6069.

@mpilgrem
Copy link
Member

I have also updated the stack.yaml and the helpers for people who use Cabal (the tool). The former will cause the CI to fail - it fails with GHC 9.4.5 in any event, because of the problems identified at #6161.

@juhp
Copy link
Contributor Author

juhp commented Jun 22, 2023

Thanks for all the fixups

@mpilgrem mpilgrem merged commit 2772faf into commercialhaskell:stack-2.9.3.1 Jun 22, 2023
@juhp juhp deleted the stack-2.9.3.1 branch June 23, 2023 01:16
@juhp
Copy link
Contributor Author

juhp commented Jul 17, 2023

Just noting that stack-2.9.3.1 is finally in lts-21.3 yay!

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants