Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Actions workflow for ARM64 #5555

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Add a GitHub Actions workflow for ARM64 #5555

merged 1 commit into from
Jun 2, 2021

Conversation

snoyberg
Copy link
Contributor

This also updates release.hs to use a more recent resolver, since
otherwise we'll have trouble on ARM64 with conflicting LLVM
installations. Unlike #5552, I took the simple workaround here of
installing GHC 8.6.5 in addition to the more recent GHC needed by
release.hs.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@snoyberg snoyberg requested a review from borsboom May 31, 2021 11:26
@snoyberg
Copy link
Contributor Author

The approach I took with modifying the installed GHC didn't work, so I'm going to take another approach instead. I've separated off the sanity check PR to #5556. #5552 can continue to deal with bumping the resolver.

Also, I'm not happy with how much this approach relies on the setup of the GitHub runner instance, so I'm going to rework the ARM installation to use Docker instead.

@snoyberg snoyberg force-pushed the arm64-runner branch 7 times, most recently from 8bdf116 to a5ad475 Compare May 31, 2021 16:37
@snoyberg
Copy link
Contributor Author

snoyberg commented Jun 1, 2021

@borsboom @qrilka this is ready for review now. I've tested, and the ARM64 bindist seems to work correctly.

@borsboom borsboom merged commit 9d61f4d into master Jun 2, 2021
@mpilgrem mpilgrem deleted the arm64-runner branch September 5, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants