Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building coverage report with Cabal 3 #5355

Merged
merged 3 commits into from
Aug 2, 2020
Merged

Fix building coverage report with Cabal 3 #5355

merged 3 commits into from
Aug 2, 2020

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Jul 29, 2020 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

Fixes #3997

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Added a test making sure that stack test --coverage for a minimal library + test suite builds a coverage report. Maybe it should be generalized to run on the latest / matrix of LTS versions?

snoyberg
snoyberg approved these changes Aug 2, 2020
View reviewed changes
Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 818ffdd into commercialhaskell:master Aug 2, 2020
@brandon-leapyear brandon-leapyear deleted the fix-coverage branch August 2, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stack test --coverage "did not consider any code", fails to produce coverage report
2 participants
@brandon-leapyear @snoyberg