Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer nightly #5167

Merged
merged 6 commits into from
Mar 10, 2020
Merged

Newer nightly #5167

merged 6 commits into from
Mar 10, 2020

Conversation

jeffhappily
Copy link
Contributor

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@snoyberg
Copy link
Contributor

snoyberg commented Feb 8, 2020

@jeffhappily can you rebase this into a single commit?

@borsboom any objection to this?

@borsboom
Copy link
Contributor

borsboom commented Feb 9, 2020

It looks like this leaves us without any GHC 8.6-based snapshot, which means we can't be guaranteed that Stack will be build-able with that version. After #5162 is merged this would be fine (since it changes snapshot.yaml to use a GHC 8.6-based snapshot), but if not a stack-lts-14.yaml and snapshot-lts-14.yaml should be added and CI configuration adjusted to also build that.

@snoyberg
Copy link
Contributor

snoyberg commented Mar 5, 2020

With the change to GHC version based Stack config files, this won't be necessary. I'll include a stack-ghc-88.yaml in the newer-lts branch instead.

@snoyberg snoyberg closed this Mar 5, 2020
@snoyberg snoyberg deleted the newer-nightly branch March 5, 2020 20:49
@snoyberg snoyberg restored the newer-nightly branch March 5, 2020 21:13
@snoyberg
Copy link
Contributor

snoyberg commented Mar 5, 2020

Just realized that the code changes in here need to be included, my mistake.

@snoyberg snoyberg reopened this Mar 5, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Still need to modify the code base here to compile.

Fix all incompatibility after upgrading to GHC 8.8.2

Hide replaceExtension on path 0.7.0 or later

Fix deprecation error
@snoyberg snoyberg merged commit 95aaf2b into master Mar 10, 2020
@snoyberg snoyberg deleted the newer-nightly branch March 10, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants