Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hackage-security expiry by default #4929

Merged
merged 1 commit into from
Jul 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ Behavior changes:
some platforms and filesystems. See
[#4876](https://github.com/commercialhaskell/stack/issues/4876).

* By default, do not perform expiry checks in Hackage Security. See
[#4928](https://github.com/commercialhaskell/stack/issues/4928).

Other enhancements:

* Do not rerun expected test failures. This is mostly a change that
Expand Down
6 changes: 5 additions & 1 deletion doc/yaml_configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,17 @@ package-indices:
key-threshold: 3 # number of keys required

# ignore expiration date, see https://github.com/commercialhaskell/stack/pull/4614
ignore-expiry: no
ignore-expiry: true
```

If you provide a replacement index which does not mirror Hackage, it
is likely that you'll end up with significant breakage, such as most
snapshots failing to work.

Note: since Stack v2.1.3, `ignore-expiry` was changed to `true` by
default. For more information on this change, see [issue
#4928](https://github.com/commercialhaskell/stack/issues/4928).

### system-ghc

Enables or disables using the GHC available on the PATH. (Make sure PATH is explicit, i.e., don't use ~.)
Expand Down
5 changes: 5 additions & 0 deletions subs/pantry/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ Bug fixes:
* Fix to allow dependencies on specific versions of local git repositories. See
[#4862](https://github.com/commercialhaskell/stack/pull/4862)

Behavior changes:

* By default, do not perform expiry checks in Hackage Security. See
[#4928](https://github.com/commercialhaskell/stack/issues/4928).

## 0.1.0.0

* Initial release
2 changes: 1 addition & 1 deletion subs/pantry/src/Pantry/Types.hs
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ instance FromJSON (WithJSONWarnings HackageSecurityConfig) where
Object o <- o' ..: "hackage-security"
hscKeyIds <- o ..: "keyids"
hscKeyThreshold <- o ..: "key-threshold"
hscIgnoreExpiry <- o ..:? "ignore-expiry" ..!= False
hscIgnoreExpiry <- o ..:? "ignore-expiry" ..!= True
pure HackageSecurityConfig {..}


Expand Down