-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't change directories when cloning a repo #4862
Conversation
I've included a Changelog update in what I think was the right place, and I believe no documentation update is necessary (already-documented behavior now works better). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline comments:
- I see that there's a CI failure from the style checker
- It may make sense to PR this against the
stable
branch instead ofmaster
ChangeLog.md
Outdated
@@ -277,6 +277,8 @@ Bug fixes: | |||
[#4292](https://github.com/commercialhaskell/stack/issues/4292) | |||
* Fix for git packages to update submodules to the correct state. See | |||
[#4314](https://github.com/commercialhaskell/stack/pull/4314) | |||
* Fix to allow dependencies on specific versions of local git repositories. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go in "unreleased changes" instead. It should also likely be mentioned in the pantry
changelog.
-- ENABLE_VIRTUAL_TERMINAL_PROCESSING flag for native terminals. The | ||
-- folowing hack re-enables the lost ANSI-capability. | ||
when osIsWindows $ void $ liftIO $ hSupportsANSIWithoutEmulation stdout | ||
runCommand ["clone", T.unpack url, dir] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment that this is intentionally not run within the withWorkingDir
below in order to allow relative paths to work.
b90cf52
to
356c662
Compare
The hlint failure was on unmodified code in a different file; I'm not inclined to touch that as part of this PR. I've adjusted the target branch, and made the changes you requested, except: the |
Right, that's intended: |
This was making it impossible to use relative file paths as repo URLs.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've merged in the changes on stable so CI will pass. This is good to merge once CI goes green.
This was making it impossible to pin to a specific commit when using relative file paths as repo URLs.
Please include the following checklist in your PR:
I tested this change by running
stack test
three times: