Fix some misplaced parse warnings #4789 #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking through this, it appears to me that we can simply remove the EDIT This comment is probably wrong, ignore it. I'll put more info in the original issue when I have it. |
Instead of FromJSON instances for Repo and PackageMetadata, use the Data.Aeson.Extended mechanisms to properly track which fields are used.
snoyberg
force-pushed
the
4789-improved-from-json-instances
branch
from
d4035f0 to
3f05443
Compare
|
I've added an additional commit which addresses a different |
snoyberg
force-pushed
the
4789-improved-from-json-instances
branch
from
5ecab98 to
bd647ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warnings about extraneous fields, by having
PackageMetadatacontent parsed within theWarningParserwhich tracks which fields are used. This does not fully address #4789, please do not close that issue when merging this.