Fix #4778: autorun autoreconf on Windows too
#4781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
reviewed
Apr 29, 2019
mpilgrem
force-pushed
the
4778-autoreconf-windows
branch
2 times, most recently
from
a405be6 to
5c4194a
Compare
snoyberg
reviewed
May 2, 2019
In module `Stack.Build.Execute`, the code uses command `sh autoreconf -i` for Windows, instead of just `autoreconf -i`. A comprehensive help message is added if `sh autoreconf -i` throws an exception on Windows. The implementation involves a hack: `sh autoreconf -i` seems to clear and not restore ANSI capability on native Windows terminals. A hack restores the ANSI capability (using the same hack that was once used for `git clone` - fix commercialhaskell#4121). This has been tested on Windows 10 (only) by deleting stack's MSYS2 (so that stack reinstalls it) and by then building the `process` package (which makes use of `configure`) using stack.
mpilgrem
force-pushed
the
4778-autoreconf-windows
branch
from
5c4194a to
873b65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In module
Stack.Setup,pacmanis used to add theperlandautoconfpackages to stack's MSYS2.In module
Stack.Build.Execute, the code uses commandsh autoreconf -ifor Windows, instead of justautoreconf -i.The implementation involves two hacks:
pacmanandsh autoreconf -iseem to clear and not restore ANSI capability on native Windows terminals. A hack restores the ANSI capability (using the same hack that was once used forgit clone- fix Fix #3992 Windows 10: Work around upstream git clone issue #4121).perlpackage (5.28.1-2) is broken. So theperlinstalled by stack is downgraded to 5.28.0-1, which works. This will need to be revisited onceperlis fixed on MSYS2.This has been tested on Windows 10 (only) by deleting stack's MSYS2 (so that stack reinstalls it) and by then building the
processpackage (which makes use ofconfigure) using stack.Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!